Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17832 BRSv46 CLDRModify passes before alpha0 #3903

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Jul 25, 2024

CLDR-17832

  • This PR completes the ticket.

The replaces the now-closed earlier PR #3900.

CLDRModify passes before alpha0:

  1. With no arguments: In personName data, add xml:space="preserve" where necessary.
  2. With -fP: In main, reformat parseLenient sets, zh_Latn exemplars; in annotations, reorder en annotations.

Note that the -fQ pass was explicitly skipped per Mark comment on earlier PR: " I don't think we should add the tts names to the keywords, unless the keywords are empty, because it works against the guidance that people should break up the search keywords by word where possible...I suggest that we hold off adding the tts name, and just do the daip (which reorders)".

Note: This should be merged with a Rebase merge (temporarily enable in Settings), not a Squash merge.

ALLOW_MANY_COMMITS=true

@pedberg-icu
Copy link
Contributor Author

To merge this when approved: Go into settings, check "Allow rebase merging", then in the PR use the popup next to the "Squash and merge" button to instead select "Rebase merge" and merge with that (to keep commits distinct on main), then go back to Settings and uncheck "Allow rebase merging".

@pedberg-icu pedberg-icu merged commit 9b0a499 into unicode-org:main Jul 25, 2024
10 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-17832-BRSv46-CLDRModify-before-alpha0-try2 branch July 25, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants